Fix APL + Change to Spell:Cast #17

Merged

4n0n merged 2 commits from LyLoLoq/Bastion:main into main 3 years ago

LyLoLoq commented 3 years ago

APL:

If we don't check for else it will always cast even if the condition results in false

Cast:

Add possibility to use functions as argument for condition making it easier to use function to check condition:

MyAPL:AddSpell(Scorch, function(self)
    -- Do stuff in here without condition inside of spell
    return false
end)

LyLoLoq added 2 commits 3 years ago

1bdf96e5ca Fix APL

If we don't check for else it will always cast even if the condition results in false

d0d16ff450 Change Spell:Cast

add possibility to use functions as argument for condition

CiscOH commented 3 years ago

confirmed this bug and the fix proposed.

LyLoLoq force-pushed main from d0d16ff450 to a84930cef2 3 years ago

LyLoLoq changed title from ~~Fix APL + Change to Spell:Cast~~ to WIP: Fix APL + Change to Spell:Cast 3 years ago

LyLoLoq changed title from ~~WIP: Fix APL + Change to Spell:Cast~~ to Fix APL + Change to Spell:Cast 3 years ago

4n0n merged commit cadb7df64e into main 3 years ago

4n0n referenced this issue from a commit 3 years ago

Merge pull request 'Fix APL + Change to Spell:Cast' (#17) from LyLoLoq/Bastion:main into main

The pull request has been merged as cadb7df64e.

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Bastion/Bastion#17